Skip to content

[qtbase] Fix almost-native builds, revise deps#46119

Merged
BillyONeal merged 10 commits intomicrosoft:masterfrom
dg0yt:qtbase
Jun 25, 2025
Merged

[qtbase] Fix almost-native builds, revise deps#46119
BillyONeal merged 10 commits intomicrosoft:masterfrom
dg0yt:qtbase

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jun 21, 2025

Amends #42080. Once again stumbling over the fact that VCPKG_CROSSCOMPILING != CMAKE_CROSSCOMPILING. And over the barely maintainable ugliness of the qt6 ports.

Fixes #45793 (arm64-osx-release on arm64-osx).
Fixes #45757 (x64-linux-dynamic on x64-linux).

@dg0yt dg0yt marked this pull request as draft June 22, 2025 06:24
@dg0yt
Copy link
Contributor Author

dg0yt commented Jun 22, 2025

So many qtbase errors in https://dev.azure.com/vcpkg/public/_build/results?buildId=117029&view=results, but I don't believe they are regressions. And failing only for test with all supported features, not for individual feature tests.

  • We never had x11 for android.
  • We never had MoltenVK for osx.
  • x11 now also fails for windows. (Who is using this BTW?)

Retrying original portfile in https://dev.azure.com/vcpkg/public/_build/results?buildId=117035&view=results. Will add to baseline what isn't a regression.

@dg0yt dg0yt mentioned this pull request Jun 22, 2025
@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Jun 23, 2025
@dg0yt
Copy link
Contributor Author

dg0yt commented Jun 23, 2025

x11 now also fails for windows. (Who is using this BTW?)

From qtbase-everywhere-src-6.8.3/src/gui/configure.cmake:

#### Libraries
qt_set01(X11_SUPPORTED LINUX OR HPUX OR FREEBSD OR NETBSD OR OPENBSD OR SOLARIS OR
    HURD)

@dg0yt dg0yt marked this pull request as ready for review June 25, 2025 03:08
@dg0yt dg0yt changed the title [qtbase] Fix almost-native builds [qtbase] Fix almost-native builds, revise deps Jun 25, 2025
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fighting through baseline hell on qt!

@BillyONeal BillyONeal merged commit 4a82168 into microsoft:master Jun 25, 2025
18 checks passed
@dg0yt dg0yt deleted the qtbase branch June 25, 2025 18:39
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 26, 2025
talregev pushed a commit to talregev/vcpkg that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[qtbase] Build failure on arm64-osx-release [qtbase] build failure

3 participants